-
Notifications
You must be signed in to change notification settings - Fork 280
Add ImpactSynth extension #2263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4e025b9 to
237475f
Compare
3d284e0 to
c0bbd19
Compare
|
@lassoan Just a small suggestion regarding the category name for ImpactSynth. The category “Image Synthesis” already exists in the Slicer Extensions Index and actually matches ImpactSynth very well. What do you think? |
|
Both "Image Synthesis" and "Segmentation" sound good to me. I understand that neither of them is perfect. Our plan is to replace a single category by a list of tags, but until this infrastructure update is ready then we would like to freeze the category list and put all extensions into existing categories. I let you decide which category you choose for now, and we'll work on adding the tag system to allow more accurate characterization in the long term. |
|
I was not suggesting introducing a new category, but commenting on naming consistency. Since existing categories use a single-noun form (e.g. Segmentation, Registration) without explicitly mentioning image, my suggestion was that Synthesis would be more consistent than Image Synthesis. That said, since the category list is currently frozen and changes are not desired at this time, I will use Image Synthesis. |
|
The rationale behind using "Image synthesis" was that "Synthesis" can mean so many things in different contexts, that the word by itself has almost no information content. Since we will replace single category by multiple tags soon, I would suggest not to spend time on trying to fix the category names now. |
|
I'm reviewing what SlicerImpactSynth extension and it seems that it very heavily relies on SlicerKonfAI - so much that it ends up being really, really small, just about 100 lines of code. Since maintaining and supporting an extension requires some effort, we usually add all very tightly linked modules into a single extension. ImpactReg module could be added to the KonfAI extension, too. What was the motivation for creating separate extensions for ImpactSynth and ImpactReg? |
|
The three extensions serve distinct and non-overlapping roles:
To minimize duplication and maintenance overhead, shared functionality is deliberately consolidated in SlicerKonfAI. This backend provides reusable infrastructure for GPU management, logging, and execution lifecycle handling, while remaining agnostic to any specific clinical task. As a result, ImpactReg and especially ImpactSynth are intentionally lightweight. This is a deliberate design choice and a direct consequence of centralizing generic functionality within a single, well-defined backend. Merging these extensions would blur the separation between generic deep learning inference, synthesis-specific applications, and registration workflows, thereby reducing architectural clarity and complicating future evolution. Keeping the extensions separate ensures clear responsibilities, independent evolution paths, and improved clinical discoverability. From a user perspective, this separation is more intuitive: synthesis, registration, and execution infrastructure are handled by distinct extensions with non-overlapping scopes, allowing users to immediately understand the purpose of each component without being exposed to unrelated functionality. |
|
The separation between generic infrastructure and specific applications, scopes, responsibilities, evolution paths, etc. is very important and it is meant to be achieved by having multiple modules in an extension. It is valid to create a separate extension for each module, but it results in unnecessary fragmentation and more complicated maintenance and user support. The only advantage may be that you get 3 entries in the extensions index, so if people browse extension names then they probably recognize that the "ImpactReg" extension is related, but they may not realize that "KonfAI" is relevant (this may be addressed in the future by introducing tags in the extension description). Fragmentation of code across multiple extensions is a significant burden for the extension maintainers, but not for Slicer maintainers, so if you feel confident that you want to proceed with this - and it seems you are - then it is not a problem for us. |
|
I've noticed that you have not checked:
Does this mean that you would not like to make the commitment to respond to issues and pull requests and creating an account on the Slicer forum so that you can be @mentioned? That's not a problem, but then we would set your extension description to be Tier 2. |
|
Yes, I do prefer to keep these components as separate extensions in order to clearly reflect three distinct categories. There is no redundant code across the three extensions, as shared functionality is centralized, which keeps the maintenance overhead minimal. I am also comfortable keeping these extensions up to date with ongoing Slicer developments. Regarding the checkboxes, I was not initially sure whether checking these boxes was meant to indicate that I already respond to issues and forum questions, or whether it represented a commitment to do so. I do intend to take on this responsibility, and I have now checked both items to reflect my commitment to responding to issues, pull requests, and questions addressed to me on the Slicer Forum. |
lassoan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All sounds good, this is ready to be merged.
New extension
Tier 1
Any extension that is listed in the Extensions Catalog must fulfill these requirements.
Slicer(unless it explicitly provides a bridge between Slicer and a tool or library), because it would make it more difficult to find extensions if the name of many started with the same word.3d-slicer-extensionGitHub topic so that it is listed here. To edit topics, click the settings icon in the right side of "About" section header and enter3d-slicer-extensionin "Topics" and click "Save changes". To learn more about topics, read https://help.github.com/en/articles/about-topicsSettingsand in repository settings uncheckWiki,Projects, andDiscussions(if they are currently not used).Aboutin the top-right corner of the repository main page and uncheckReleasesandPackages(if they are currently not used)Tier 3
Community-supported extensions.
Tier 5
Critically important extensions, supported by Slicer core developers. New Slicer Stable Release is released only if all Tier 5 extension packages are successfully created on all supported platforms.
This PR adds ImpactSynth, a new extension enabling synthetic CT (sCT) generation from MRI or CBCT directly inside 3D Slicer, specifically designed for radiotherapy workflows.
Slicer IMPACT-Synth provides a dedicated GUI for the IMPACT-Synth framework and leverages KonfAI Apps for fast and fully configurable inference pipelines.
It integrates state-of-the-art models from the SynthRAD2025 Challenge (ranked 3rd in both MRI→CT and CBCT→CT tasks) and includes embedded evaluation and uncertainty workflows to support clinical Quality Assurance.
Included capabilities
Image Synthesis
Segmentation & QA
Integration-focused design
We welcome feedback and suggestions from the Slicer team!